[PATCH] D135523: Adds absolute and pc relative relocation support for ELF/i386

[Kshitij Jain via Phabricator via llvm-commits]

jain98 added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELFLinkGraphBuilder.h:505
+Error ELFLinkGraphBuilder<ELFT>::forEachRelaRelocation(
+    const typename ELFT::Shdr &RelSect, RelocHandlerMethod &&Func,
     bool ProcessDebugSections) {
----------------
sgraenitz wrote:
> Nit: We should keep typename Function here as well as for forEachRelRelocation()
I can change it back to "RelocHandlerFunction". I purposely changed it to "RelocHandlerMethod" because "Func" argument was a member function (which at least in Rust are just referred to as methods. Perhaps they're not called the same thing in C++). Is there a reason why you named the template parameter "RelocHandlerFunction"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135523/new/

https://reviews.llvm.org/D135523