[PATCH] D135982: [SimplifyCFG] Try unsigned case value for switch to lookup table

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 16:01:07 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6373
+  // try unsigned if the case value is signed overflow
+  if (MinCaseVal->isMinSignedValue() && MaxCaseVal->isMaxValue(true)) {
+    for (auto Case : SI->cases()) {
----------------
Why not use `isMaxSignedValue` to be consistent with the use of `isMinSignedValue`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135982/new/

https://reviews.llvm.org/D135982



More information about the llvm-commits mailing list