[PATCH] D119050: [llvm-objdump/mac] Add new function starts print mode

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 14:35:00 PDT 2022


keith added inline comments.


================
Comment at: llvm/tools/llvm-objdump/MachODump.h:37
 
+enum FunctionStartsMode { FSAddrs, FSNames, FSBoth, FSNone };
+
----------------
smeenai wrote:
> smeenai wrote:
> > Nit: I think an `enum class` would be nicer here.
> Sorry for being nitty again, but you can remove the `FS` prefix now that it's an `enum class` (which was the motivation for my suggestion).
good point, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119050/new/

https://reviews.llvm.org/D119050



More information about the llvm-commits mailing list