[PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 13:43:49 PDT 2022


rahmanl added a comment.

In D100808#3854974 <https://reviews.llvm.org/D100808#3854974>, @jhenderson wrote:

> No more comments from me, thanks.

I appreciate the review @jhenderson



================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:224
       // set every basic block's section ID equal to its number (basic block
       // id). This further ensures that basic blocks are ordered canonically.
+      MBB.setSectionID(PreLayoutPosition.lookup(&MBB));
----------------
jhenderson wrote:
> 
Changed the comment as it doesn't hold anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100808/new/

https://reviews.llvm.org/D100808



More information about the llvm-commits mailing list