[PATCH] D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.


================
Comment at: compiler-rt/test/tsan/Linux/check_memcpy.c:10
 
+// XFAIL: !compiler-rt-optimized
+
----------------
ro wrote:
> vitalybuka wrote:
> > vitalybuka wrote:
> > > I see, XFAIL will run the test. So if it's about timeouts, it will still timeout.
> > > 
> > > Just make it
> > > // REQUIRES: compiler-rt-optimized
> > 
> > I see, XFAIL will run the test. So if it's about timeouts, it will still timeout.
> > 
> > Just make it
> > // REQUIRES: compiler-rt-optimized
> 
> It's not: the test `FAIL`s at `-O0` with
> ```
> /vol/llvm/src/llvm-project/local-debug/compiler-rt/test/tsan/Linux/check_memcpy.c:17:15: error: CHECK-NOT: excluded string found in input
> // CHECK-NOT: callq {{.*<(__interceptor_)?mem(cpy|set)>}}
>               ^
> <stdin>:47254:24: note: found here
>  454dc: e8 4f d4 02 00 callq 0x72930 <memset>
>                        ^~~~~~~~~~~~~~~~~~~~~~
> ```
> i.e. `memset` isn't inlined unlike at `-O1`.  This is to be expected, I think, thus the `XFAIL`.
> > I see, XFAIL will run the test. So if it's about timeouts, it will still timeout.
> > 
> > Just make it
> > // REQUIRES: compiler-rt-optimized
> 
> It's not: the test `FAIL`s at `-O0` with
> ```
> /vol/llvm/src/llvm-project/local-debug/compiler-rt/test/tsan/Linux/check_memcpy.c:17:15: error: CHECK-NOT: excluded string found in input
> // CHECK-NOT: callq {{.*<(__interceptor_)?mem(cpy|set)>}}
>               ^
> <stdin>:47254:24: note: found here
>  454dc: e8 4f d4 02 00 callq 0x72930 <memset>
>                        ^~~~~~~~~~~~~~~~~~~~~~
> ```
> i.e. `memset` isn't inlined unlike at `-O1`.  This is to be expected, I think, thus the `XFAIL`.

Thanks. Looks like I identified the source of timeouts incorrectly.
I guess you should try to land it. If necessary we can revert and reiterate again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91620/new/

https://reviews.llvm.org/D91620