[PATCH] D135943: [lld][nfc] Remove lld::demangle() (partial revert of D116279)

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 12:07:51 PDT 2022


int3 added inline comments.


================
Comment at: lld/wasm/Symbols.cpp:39
+    return demangle(std::string(name));
+  return std::string(name);
 }
----------------
sbc100 wrote:
> Is using `std::string(name)` preferable to `name.str()` ?
no idea. Most of the original code used the `std::string` constructor though. But... `.str()` is fewer characters and looks cleaner. I'll switch them over.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135943/new/

https://reviews.llvm.org/D135943



More information about the llvm-commits mailing list