[PATCH] D135903: [wasm-ld] Add support for calling constructors in reactors.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 11:17:02 PDT 2022


sbc100 added a comment.

lso, IIUC if `_initialize` exists and calls `__wasm_call_ctors` then these wrappers won't be generated (because `__wasm_call_ctors` will be referenced)  .. so this solution doesn't help modules that contain a valid `_initialize` function.

> Yeah; the next step here will be to change the clang driver to stop passing `--entry=_initialize` and use `--no-entry` when linking a reactor, which will stop emitting `_initialize` and enable the wrappers.

Ok, so if emscripten (or any other toolchain) wants to continue to handle initialization using `_start` (function name not section name) and/or `_initialize` then it won't pay the cost of the extra wrappers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135903/new/

https://reviews.llvm.org/D135903



More information about the llvm-commits mailing list