[PATCH] D135897: [LLD][ELF] --wrap: __real_foo references should trigger archive extraction for foo

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

This makes sense to me, and I tested it internally and confirmed it doesn't change anything for us, but I'd prefer @MaskRay to take a look as well.



================
Comment at: lld/test/ELF/wrap-extract-real.ll:19
+# REAL-NEXT:        {{.*}}           {{.*}} FUNC    GLOBAL DEFAULT     2 _start
+# REAL-NEXT:        {{.*}}           {{.*}} FUNC    WEAK   DEFAULT     2 foo
+# REAL-NEXT:        {{.*}}           {{.*}} NOTYPE  GLOBAL DEFAULT   UND __wrap_foo
----------------
Why does this become weak? (It's global for the assembly test case, which is what I'd expect.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135897/new/

https://reviews.llvm.org/D135897