[PATCH] D135359: [lld-macho] Don't fold DWARFs with CompactUnwinds

Fri Oct 14 10:21:30 PDT 2022

oontvoo added inline comments.

================
Comment at: lld/MachO/UnwindInfoSection.cpp:400-403
+  // Can't fold DWARF sections.
+  if ((encoding & static_cast<uint32_t>(UNWIND_X86_64_MODE_MASK)) ==
+      target->modeDwarfEncoding)
+    return false;
----------------
int3 wrote:
> Unless there's an obvious runtime issue, I would rather we keep things the way they are. Is there any observable behavioral difference with this change?
> 
> DWARF mode encodings will almost (always?) never get folded anyway since each one includes an offset to the corresponding EH frame. And since we don't do ICF on EH frames, they should all be distinct...
(reverted this for now - will send a different patch w.r.t dwarf handling)

This patch will now be mostly NFC

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135359/new/

https://reviews.llvm.org/D135359