[PATCH] D135909: [LoopDeletion] Move block and loop dispo invalidation to makeLoopInvar.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 467802.
fhahn added a comment.

In D135909#3856829 <https://reviews.llvm.org/D135909#3856829>, @fhahn wrote:

> In D135909#3856806 <https://reviews.llvm.org/D135909#3856806>, @nikic wrote:
>
>> Generally LGTM, but don't you need to adjust the usage in LoopSimplify as well?
>
> Yes we should probably update all users that preserve SCEV in general. We unfortunately don't have SCEV verification tests for LoopSimplify, but I'll see if I can add one.

I wasn't able to come up with a loop-simplify test case, but I updated the use of makeLoopInvariant in LoopSimplify.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135909/new/

https://reviews.llvm.org/D135909

Files:
  llvm/include/llvm/Analysis/LoopInfo.h
  llvm/lib/Analysis/LoopInfo.cpp
  llvm/lib/Transforms/Scalar/LoopDeletion.cpp
  llvm/lib/Transforms/Utils/LoopSimplify.cpp
  llvm/test/Transforms/LoopDeletion/invalidate-scev-after-hoisting.ll
  llvm/test/Transforms/LoopDeletion/pr57837-invalidate-scev-after-hoisting.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135909.467802.patch
Type: text/x-patch
Size: 6324 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221014/67782e27/attachment.bin>