[PATCH] D133433: [AArch64]: Force generating code compatible to streaming mode

Hassnaa Hamdi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 08:43:43 PDT 2022


hassnaa-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:441
+  if (ForceStreamingCompatibleSVE) {
+    assert(hasSVE() && "Expected SVE to be available");
+    return hasSVE() || hasSME();
----------------
paulwalker-arm wrote:
> I guess this should match the code below, although I'm not quite sure why the assert it needed.
If someone forces using streaming-compatible code, SVE must be available. (and given that its not a user-exposed feature in Clang, it's fine for the compiler to crash if someone would use this feature while forgetting to set +sve somehow)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133433/new/

https://reviews.llvm.org/D133433



More information about the llvm-commits mailing list