[PATCH] D135597: [LangRef] Add memory attribute
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 14 08:28:08 PDT 2022
nikic added a comment.
In D135597#3858550 <https://reviews.llvm.org/D135597#3858550>, @xbolva00 wrote:
> Just FYI,
>
> https://github.com/llvm/llvm-project/issues/54312 :
>
>> I would recommend not to add size to the existing ones but instead replace them as whole. That said, mapping all but the size argument to existing ones would be great and pretty straight forward (IMHO).
>
> What do you think, should 'memory' attribute take arg-index and size-index into account to support use cases like access attribute in C?
I don't think so. The memory attribute describes the memory effects of the whole call/function. We have separate attributes that apply to individual arguments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135597/new/
https://reviews.llvm.org/D135597
More information about the llvm-commits
mailing list