[PATCH] D135597: [LangRef] Add memory attribute

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 07:45:50 PDT 2022


nikic marked 3 inline comments as done.
nikic added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1767
+      default access kind that covers ``other``, rather than enumerating all
+      currently supported location kinds.
+
----------------
jdoerfert wrote:
> I'm still not super happy with this scheme. `other` is all the location kinds we do not explicitly enumerate at at the current time, which is subject to change. At the same time we have an implicit "default" location kind which we don't even list in the "possible memory location kinds" above. So, we have two ways to refer to things not specified explicitly and they mean different things, that's confusing. Long story short, do we really need other?
Okay, I went ahead and dropped `other`. I don't really see a use for it, and I agree that having both other and the default is somewhat confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135597/new/

https://reviews.llvm.org/D135597



More information about the llvm-commits mailing list