[PATCH] D135873: Detect Visual Studio automatically in Windows packaging script

Pierrick Bouvier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 07:29:15 PDT 2022


pbo-linaro marked an inline comment as done.
pbo-linaro added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:90
+if "%VSINSTALLDIR%" NEQ "" (
+  echo use enabled Visual Studio installation
+  set "vsinstall=%VSINSTALLDIR%"
----------------
hans wrote:
> "use" sounds like it's asking the user to do something. Maybe it should say "using" instead?
You're right. I just updated it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135873/new/

https://reviews.llvm.org/D135873



More information about the llvm-commits mailing list