[PATCH] D135873: Detect Visual Studio automatically in Windows packaging script

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 07:15:31 PDT 2022


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/utils/release/build_llvm_release.bat:90
+if "%VSINSTALLDIR%" NEQ "" (
+  echo use enabled Visual Studio installation
+  set "vsinstall=%VSINSTALLDIR%"
----------------
"use" sounds like it's asking the user to do something. Maybe it should say "using" instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135873/new/

https://reviews.llvm.org/D135873



More information about the llvm-commits mailing list