[PATCH] D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.cpp:1193
+
+    Symbol->addLocation(Attr, 0, 0, 0, 0);
+    Symbol->addLocationOperands(LVSmall(Attr), Operand1, /*Operand2=*/0);
----------------
zequanwu wrote:
> Why is Range set for `S_DEFRANGE_FRAMEPOINTER_REL` and `S_DEFRANGE_REGISTER_REL` but not set for `S_DEFRANGE_REGISTER`, `S_DEFRANGE_SUBFIELD_REGISTER`?
Good point. I missed the `LocalVariableAddrRange` information.

Added for both `S_DEFRANGE_REGISTER`, `S_DEFRANGE_SUBFIELD_REGISTER` range information.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784