[PATCH] D135564: [AArch64-SVE]: Force generating code compatible to streaming mode.

[Hassnaa Hamdi via Phabricator via llvm-commits]

hassnaa-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11925
+  if (useSVEForFixedLengthVectorVT(Op.getValueType(),
+                                   Subtarget->forceStreamingCompatibleSVE()))
     return LowerFixedLengthConcatVectorsToSVE(Op, DAG);
----------------
SjoerdMeijer wrote:
> Drive by comment:
> 
> we don't need to pass `Subtarget->forceStreamingCompatibleSVE()` but can just query that inside `useSVEForFixedLengthVectorVT`?
I think we still need to pass it, because `useSVEForFixedLengthVectorVT` is used in many places, some of them don't need the flag to be enabled.
The flag is used for enabling lowering specific nodes that cause generating invalid code in streaming mode.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135564/new/

https://reviews.llvm.org/D135564