[PATCH] D134938: Use builtins in <math.h>

[Michael Platings via Phabricator via llvm-commits]

michaelplatings added inline comments.


================
Comment at: libcxx/include/math.h:794
+inline _LIBCPP_HIDE_FROM_ABI float acos(float __x) _NOEXCEPT {
+#      if __has_builtin(__builtin_acosf)
+  return __builtin_acosf(__x);
----------------
ldionne wrote:
> Can't we assume that we always have the builtin available?
I don't know. D88854, D106364 and D69806 all made sure to add the __has_builtin check. Has something changed since then? Or do you anticipate that it's only necessary for certain functions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134938/new/

https://reviews.llvm.org/D134938