[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:781
+    Builder.defineMacro("__AVXNECONVERT__");
+  Builder.defineMacro("__AVXNECONVERT_SUPPORTED__");
   if (HasAVXVNNI)
----------------
LuoYuanke wrote:
> Do we need it here?
We don't need it.


================
Comment at: clang/lib/Headers/immintrin.h:257
 
+/* FIXME: Change these When _Float16 type is supported */
+#if defined(__AVXNECONVERT__) && defined(__AVX512FP16__)
----------------
craig.topper wrote:
> Is this FIXME still relevant? Don't we support _Float16 with SSE2 now?
_Float16 is supported with SSE2, but maybe we need to move `__m128h`, `__m256h` out of avx512fp16intrin.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135930/new/

https://reviews.llvm.org/D135930