[PATCH] D135937: [X86] Support -march=meteorlake

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 21:47:41 PDT 2022


craig.topper added inline comments.


================
Comment at: clang/test/CodeGen/target-builtin-noerror.c:129
   (void)__builtin_cpu_is("tremont");
+  (void)__builtin_cpu_is("meteorlake");
   (void)__builtin_cpu_is("westmere");
----------------
I think this list was once in alphabetical order


================
Comment at: compiler-rt/lib/builtins/cpu_model.c:110
   INTEL_COREI7_ROCKETLAKE,
+  INTEL_COREI7_METEORLAKE,
   CPU_SUBTYPE_MAX
----------------
The raptorlake patch also puts a constant here. What is the correct order? Can you please rebase one patch on top of the other or merge them into a single patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135937/new/

https://reviews.llvm.org/D135937



More information about the llvm-commits mailing list