[PATCH] D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 19:28:19 PDT 2022


beanz added inline comments.


================
Comment at: llvm/lib/ObjCopy/MachO/MachOLayoutBuilder.cpp:255
+  }
+  assert((DyldInfoExportsTrieSize == 0 || DyldExportsTrieSize == 0) &&
+         "Export trie in both LCs");
----------------
Hypothetically, without this assert does the code otherwise function to generate the export trie twice?

The reason I'm asking, is that one of the original goals for the mach-o yaml tooling was to be able to construct invalid object files for testing purposes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134571/new/

https://reviews.llvm.org/D134571



More information about the llvm-commits mailing list