[PATCH] D134972: [CMake] Only set LLVM_DEFAULT_TARGET_TRIPLE to LLVM_HOST_TRIPLE when native target is enabled

Thu Oct 13 18:30:33 PDT 2022

smeenai added a comment.

In D134972#3848313 <https://reviews.llvm.org/D134972#3848313>, @python3kgae wrote:

> In D134972#3848302 <https://reviews.llvm.org/D134972#3848302>, @smeenai wrote:
>
>> Unfortunately I'm not set up for AMDGPU, so I can't test that locally. Just to confirm, `check-llvm` works for you if `LLVM_DEFAULT_TARGET_TRIPLE` is empty, but not if it's set to a triple corresponding to an enabled backend?
>
> Yes. check-llvm works if `LLVM_DEFAULT_TARGET_TRIPLE` is empty. ( except 2 OrcV2Examples in this patch).
> Then set it to amdgcn-amd-amdhsa get lot of fails.

Hmm. Do you have an example of a failing test and why it's failing? (I see lots of amdhsa failures on my end, but I'm pretty sure it's just because I'm not set up correctly.) I'm trying to understand why the default triple is making a difference here, vs. just having the backend enabled or not enabled, and what the behavior is when the default triple is empty that's making the test pass.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134972/new/

https://reviews.llvm.org/D134972