[PATCH] D119050: [llvm-objdump/mac] Add new function starts print mode

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a reviewer: thakis.
smeenai added a comment.

Generally looks good to me. Adding Nico in case he has any feedback as well.



================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:1107
+      if (It != SymbolNames.end())
+        outs() << It->second << "\n";
+    } else {
----------------
So if we can't find the address associated with a symbol, we don't print anything for it? Does that match dyldinfo's behavior? Should we have a test for it?


================
Comment at: llvm/tools/llvm-objdump/MachODump.h:37
 
+enum FunctionStartsMode { FSAddrs, FSNames, FSBoth, FSNone };
+
----------------
Nit: I think an `enum class` would be nicer here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119050/new/

https://reviews.llvm.org/D119050