[PATCH] D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.

Agreed that having everything canonicalized to use preferred load address as base is clean and practical. Thanks for making the changes. LGTM with a nit.



================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.h:353
+  // Convert to preferred load address based address.
+  uint64_t convertAddress(uint64_t Address) {
+    return Address - BaseAddress + getPreferredBaseAddress();
----------------
nit: `canonicalizeVirtualAddress` is probably a better name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126827/new/

https://reviews.llvm.org/D126827