[PATCH] D70515: [WebAssembly] Create a __stack_limit variable

Thu Oct 13 14:58:00 PDT 2022

sbc100 added a comment.
Herald added subscribers: pmatos, asb, ecnelises.
Herald added a project: All.

Sorry, I have somehow forgotten about this change when I created https://reviews.llvm.org/D135910.

I'm not sure if something like this also needed?  Unlike the two variables I created this global is thread local which means it could be more useful in mutli-thread environments.   In emscripten we currently inject a (TLS) wasm global to aid with stack checking:  https://github.com/emscripten-core/emscripten/blob/af961ad5c4c278ec510f0b7f7d522a95ee5a90f8/system/lib/compiler-rt/stack_limits.S#L21-L24.. but I suppose having the linker so it could also make sense.

Do you think this change is still useful and/or better than https://reviews.llvm.org/D135910?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70515/new/

https://reviews.llvm.org/D70515