[PATCH] D135402: [LLD] Enable --no-undefined-version by default.
Slava Zakharin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 13 14:42:05 PDT 2022
vzakhari added a comment.
I am not volunteering, but here is my thoughts.
@jhuber6, @ronlieb, do you know why the `lld` build started failing after this change? Is there `--fatal-warnings` option specified for the linker invocations?
If we remove `--fatal-warnings` this should allow @danalbert to reland this patch, and then the warnings can be phased out incrementally. Does it make sense?
Or, alternatively, `lld` default may be changed to always warn-on-undefined-symbols-in-version-script but never treat this as an error, unless `--fatal-warnings` and `--undefined-version` are both explicitly specified (to match legacy behavior). This may result in some convoluted user experience.
I have a general question though: is `lld` supposed to be a verbatim replacement for `ld` and vice versa? Is it okay to allow different user-visible behavior for the two tools?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135402/new/
https://reviews.llvm.org/D135402
More information about the llvm-commits
mailing list