[PATCH] D135904: [SPIR-V] Add get_image_num_mip_levels implementation

Andrey Tretyakov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 13:09:54 PDT 2022


andreytr added inline comments.


================
Comment at: llvm/test/CodeGen/SPIRV/transcoding/get_image_num_mip_levels.ll:4-27
+; CHECK-DAG: %[[#INT:]] = OpTypeInt 32
+; CHECK-DAG: %[[#VOID:]] = OpTypeVoid
+; CHECK-DAG: %[[#IMAGE1D_T:]] = OpTypeImage %[[#VOID]] 1D 0 0 0 0 Unknown ReadOnly
+; CHECK-DAG: %[[#IMAGE2D_T:]] = OpTypeImage %[[#VOID]] 2D 0 0 0 0 Unknown ReadOnly
+; CHECK-DAG: %[[#IMAGE3D_T:]] = OpTypeImage %[[#VOID]] 3D 0 0 0 0 Unknown ReadOnly
+; CHECK-DAG: %[[#IMAGE1D_ARRAY_T:]] = OpTypeImage %[[#VOID]] 1D 0 1 0 0 Unknown ReadOnly
+; CHECK-DAG: %[[#IMAGE2D_ARRAY_T:]] = OpTypeImage %[[#VOID]] 2D 0 1 0 0 Unknown ReadOnly
----------------
Suggest to fix %{{[0-9]+}} -> %[[#]]
and indentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135904/new/

https://reviews.llvm.org/D135904



More information about the llvm-commits mailing list