[PATCH] D135340: [PGO] Make emitted symbols hidden

[Cyndy Ishida via Phabricator via llvm-commits]

cishida accepted this revision.
cishida added a comment.

This change LGTM. My understanding of the history here, is that these symbols were exported expecting to be eventually referenced when profiling options are used but weren't always consistently exported. This kind of inconsistency of symbol exports breaks TAPI verification. In the recent past we've had a similar issue where the symbols got optimized out based on the optimization level.  If `__llvm_profile_raw_version` and `__llvm_profile_filename` always have hidden visibility this should be fine for TAPI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135340/new/

https://reviews.llvm.org/D135340