[PATCH] D135900: [AMDGPU][MC][GFX8+] Correct v_cndmask modifiers

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 11:48:25 PDT 2022


dp created this revision.
dp added reviewers: foad, Joe_Nash, rampitec.
Herald added subscribers: kosarev, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
dp requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Correct `v_cndmask_b32` to support abs/neg modifiers in `dpp/sdwa/e64` variants.
Correct `v_cndmask_b16` for proper disassembly of abs/neg modifiers in `e64_dpp` variants.

See this bug <https://github.com/llvm/llvm-project/issues/58324> for more information.


https://reviews.llvm.org/D135900

Files:
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
  llvm/lib/Target/AMDGPU/VOP2Instructions.td
  llvm/test/MC/AMDGPU/gfx10_asm_vop2.s
  llvm/test/MC/AMDGPU/gfx10_err_pos.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop2_dpp16.s
  llvm/test/MC/AMDGPU/gfx7_asm_vop3.s
  llvm/test/MC/AMDGPU/gfx8_asm_vop2.s
  llvm/test/MC/AMDGPU/gfx8_asm_vop3.s
  llvm/test/MC/AMDGPU/gfx8_err_pos.s
  llvm/test/MC/AMDGPU/gfx9_asm_vop2.s
  llvm/test/MC/AMDGPU/gfx9_asm_vop3.s
  llvm/test/MC/AMDGPU/gfx9_err_pos.s
  llvm/test/MC/AMDGPU/vop_sdwa.s
  llvm/test/MC/Disassembler/AMDGPU/gfx10_vop2_dpp16.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx10_vop2_sdwa.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx10_vop3.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop2_dpp16.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3_dpp16.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3_dpp8.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx8_vop2_dpp.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx8_vop2_sdwa.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx8_vop3.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx9_sdwa_features.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx9_vop2_dpp.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx9_vop3.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135900.467546.patch
Type: text/x-patch
Size: 40304 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221013/86c935d0/attachment.bin>


More information about the llvm-commits mailing list