[PATCH] D135038: [lld/mac] Port typo correction for undefined symbols from ELF port

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D135038#3855955 <https://reviews.llvm.org/D135038#3855955>, @thakis wrote:

> In D135038#3848082 <https://reviews.llvm.org/D135038#3848082>, @dblaikie wrote:
>
>> (FWIW, my 2c & this dates back to the founding of the 'new' (now not-so-new) lld - that the code duplication between ports is pretty unfortunate & while it does give some agility
>
> Not sure if this is the right forum to re-litigate this :) I'm sure you're aware of the history: The original lld used a design like this and didn't go anywhere. The new lld uses this somewhat uncommon approach, and it's led to lld becoming the fastest production quality linker that can target COFF, ELF, and MachO. Abstractly I kind of agree with you, but you also can't argue too much with the impact the current approach had.

One of the arguments made early on was that unlibrary-ification would be necessary for early velocity (not one I agree with, but that's how it went) & that library-ification could occur once development was over that hump/had got concrete results. Given that lld's been proved out and is a production linker, I think now's a good time to start considering looking for commonality and migrating towards more common infrastructure and library-like design.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135038/new/

https://reviews.llvm.org/D135038