[PATCH] D135889: [lld/mac] Add test for bug fixed in reland 82ca390062d115

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 09:02:29 PDT 2022


thakis added a comment.

Thanks!



================
Comment at: lld/test/MachO/undef-spell-corrector.s:91-93
+.section  __DWARF,__debug_aranges,regular,debug
+ltmp1:
+  .byte 0
----------------
int3 wrote:
> what was the bug? could we have a comment explaining why this debug section was added to the test?
This causes ObjFile::symbols to contain a nullptr. The original patch used dyn_cast for all symbols in ObjFile::symbols. The fix was to use dyn_cast_or_null.

Will add a comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135889/new/

https://reviews.llvm.org/D135889



More information about the llvm-commits mailing list