[PATCH] D135038: [lld/mac] Port typo correction for undefined symbols from ELF port

Thu Oct 13 08:55:24 PDT 2022

tschuett added a comment.

In D135038#3855955 <https://reviews.llvm.org/D135038#3855955>, @thakis wrote:

> In D135038#3848082 <https://reviews.llvm.org/D135038#3848082>, @dblaikie wrote:
>
>> (FWIW, my 2c & this dates back to the founding of the 'new' (now not-so-new) lld - that the code duplication between ports is pretty unfortunate & while it does give some agility
>
> Not sure if this is the right forum to re-litigate this :) I'm sure you're aware of the history: The original lld used a design like this and didn't go anywhere. The new lld uses this somewhat uncommon approach, and it's led to lld becoming the fastest production quality linker that can target COFF, ELF, and MachO. Abstractly I kind of agree with you, but you also can't argue too much with the impact the current approach had.

mold might disagree about speed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135038/new/

https://reviews.llvm.org/D135038