[PATCH] D135883: [lld-macho] Include symbol sizes in mapfile

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/test/MachO/map-file.s:62
 # DEADCSTRING-LABEL: Dead Stripped Symbols:
-# DEADCSTRING-DAG: literal string: Hello, it's me
+# DEADCSTRING-DAG:   <<dead>> 0x0000000F [  1] literal string: Hello, it's me
 
----------------
oontvoo wrote:
> why do dead symbols need sizes and not addresses? (is that LD64's output too?)
I mean, there are no addresses to emit for dead symbols since they don't appear in the output, but they do still have sizes based on their size in the input object file :)

and yes this is what ld64 does too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135883/new/

https://reviews.llvm.org/D135883