[PATCH] D135877: [lld/mac] Make two local variables const
Vy Nguyen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 13 08:05:47 PDT 2022
oontvoo accepted this revision.
oontvoo added a comment.
LG
================
Comment at: lld/MachO/InputFiles.cpp:813
StringRef name = strtab + sym.n_strx;
uint64_t symbolOffset = sym.n_value - sectionAddr;
InputSection *isec =
----------------
tschuett wrote:
> tschuett wrote:
> > symbolOffset is not const?
> Sorry. It is **not** const.
I had the same question - then I saw that findCOntainingSubsection() takes an output param.
any objection to refactoring that too - then this one could be const? (doesn't have to be in this patch)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135877/new/
https://reviews.llvm.org/D135877
More information about the llvm-commits
mailing list