[PATCH] D135877: [lld/mac] Make two local variables const

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 07:56:43 PDT 2022


tschuett added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:813
         StringRef name = strtab + sym.n_strx;
         uint64_t symbolOffset = sym.n_value - sectionAddr;
         InputSection *isec =
----------------
symbolOffset is not const?


================
Comment at: lld/MachO/InputFiles.cpp:844
       size_t symbolOffset = sym.n_value - subsecAddr;
       uint64_t symbolSize =
           j + 1 < symbolIndices.size()
----------------
These integers are not const?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135877/new/

https://reviews.llvm.org/D135877



More information about the llvm-commits mailing list