[PATCH] D135402: [LLD] Enable --no-undefined-version by default.

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 added a comment.

In D135402#3855331 <https://reviews.llvm.org/D135402#3855331>, @ronlieb wrote:

> hi, our amdgpu buildbot which uses lld has been failing since this commit landed
> https://lab.llvm.org/buildbot/#/builders/193/builds/20055

I addressed those issues by adding  `--undefined-version` to everywhere that used the version scripts.

I've recently been getting a few spurious build failures after this patch for. Getting rid of the following exported symbols seems to fix it, but I'm not sure if this is the correct solution or these are spuriously undefined.

  diff --git a/llvm/tools/lto/lto.exports b/llvm/tools/lto/lto.exports
  index 3abae5f0fcba..4164c3919a97 100644
  --- a/llvm/tools/lto/lto.exports
  +++ b/llvm/tools/lto/lto.exports
  @@ -45,12 +45,6 @@ lto_codegen_compile_optimized
   lto_codegen_set_should_internalize
   lto_codegen_set_should_embed_uselists
   lto_set_debug_options
  -LLVMCreateDisasm
  -LLVMCreateDisasmCPU
  -LLVMDisasmDispose
  -LLVMDisasmInstruction
  -LLVMSetDisasmOptions
  -LLVMCreateDisasmCPUFeatures
   thinlto_create_codegen
   thinlto_codegen_dispose
   thinlto_codegen_add_module


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135402/new/

https://reviews.llvm.org/D135402