[PATCH] D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewReader.h:37
+};
+} // namespace llvm
+
----------------
probinson wrote:
> Looks funny to close off a namespace and then immediately open it again.
> I could see doing that after the forward declaration of SymbolGroup (below) as a way to delimit "things from outside of `logicalview`, and then you would introduce all the local things with the familiar pair of lines:
> ```
> namespace llvm {
> namespace logicalview {
> ```
> But all this is just aesthetics, up to you really.
I will go with you on this one: `aesthetics` 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784