[PATCH] D135738: [InstCombine] Bail out of casting calls when a conversion to byval is involved.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 01:17:34 PDT 2022


nikic added a comment.

In D135738#3854021 <https://reviews.llvm.org/D135738#3854021>, @glandium wrote:

>> From a quick try, the same is true for argument promotion (https://llvm.godbolt.org/z/8We7dvYvT), we mix up the levels of indirection.
>
> This one doesn't happen without `internal`, which wouldn't happen in a real cross-module case, would it?

It can happen after fat LTO internalization. For thin LTO, I don't think it's possible right now (though I believe someone is working on supporting ThinLTO arg promotion, so that may not hold up in the future...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135738/new/

https://reviews.llvm.org/D135738



More information about the llvm-commits mailing list