[PATCH] D135040: [llvm-objdump] Add --no-addresses as an alias for --no-leading-addr

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/ObjdumpOpts.td:133
   HelpText<"When disassembling, do not print leading addresses for instructions or inline relocations">;
+def : Flag<["--"], "no-addresses">, Alias<no_leading_addr>;
 
----------------
jhenderson wrote:
> Just a quick note: unless something has changed at some point (I don't have a quick way to build and check llvm-objdump currently, or I'd check myself), because this has no help text, I believe it won't appear in the list of options listed by `--help`. This means that the documentation and the help text won't agree with one another, which seems less than ideal.
Append `, HelpText<"Alias for --no-leading-addr">`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135040/new/

https://reviews.llvm.org/D135040