[PATCH] D135837: [mlir][MemRef] Simplify extract_strided_metadata(reinterpret_cast)

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 18:15:25 PDT 2022


qcolombet added inline comments.


================
Comment at: mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp:690
+    // Check if the source is suitable for extract_strided_metadata.
+    if (!reinterpretCastOp.getSource().getType().isa<MemRefType>())
+      return rewriter.notifyMatchFailure(
----------------
Is there a generic way of doing that?
Something like `ExtractStridedMetadata::verifySourceType`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135837/new/

https://reviews.llvm.org/D135837



More information about the llvm-commits mailing list