[PATCH] D135789: Add .editorconfig file

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 16:52:41 PDT 2022


MaskRay added a comment.

This seems useful as it does apply to a lot of editors. If it were Visual Studio alone I would be unsure whether this passed the bar :)



================
Comment at: .editorconfig:9
+trim_trailing_whitespace = true
+
----------------
beanz wrote:
> mgorny wrote:
> > Does it have some key not to add empty trailing lines? ;-)
> The `insert_final_newline` adds that line, which is generally what we want because strict C states that all files should end with a newline. Both GCC and Clang have warnings for that.
Remove the trailing blank line.


================
Comment at: .editorconfig:9
+trim_trailing_whitespace = true
+
----------------
MaskRay wrote:
> beanz wrote:
> > mgorny wrote:
> > > Does it have some key not to add empty trailing lines? ;-)
> > The `insert_final_newline` adds that line, which is generally what we want because strict C states that all files should end with a newline. Both GCC and Clang have warnings for that.
> Remove the trailing blank line.
Do we need `end_of_line = lf`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135789/new/

https://reviews.llvm.org/D135789



More information about the llvm-commits mailing list