[PATCH] D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`

Argyrios Kyrtzidis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 13:58:50 PDT 2022


akyrtzi updated this revision to Diff 467256.
akyrtzi added a comment.

ProvenanceAnalysis::relatedPHI: Return true only if both `comparePHISources()` calls return `true`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135376/new/

https://reviews.llvm.org/D135376

Files:
  llvm/lib/Transforms/ObjCARC/ProvenanceAnalysis.cpp


Index: llvm/lib/Transforms/ObjCARC/ProvenanceAnalysis.cpp
===================================================================
--- llvm/lib/Transforms/ObjCARC/ProvenanceAnalysis.cpp
+++ llvm/lib/Transforms/ObjCARC/ProvenanceAnalysis.cpp
@@ -78,8 +78,8 @@
       return false;
     }
 
-    if (comparePHISources(PNB, A))
-      return true;
+    if (!comparePHISources(PNB, A))
+      return false;
   }
 
   return comparePHISources(A, B);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135376.467256.patch
Type: text/x-patch
Size: 440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221012/46088c6c/attachment.bin>


More information about the llvm-commits mailing list