[PATCH] D135638: [MC] Also sort on IsBKeyFrame
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 12 12:55:34 PDT 2022
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/test/MC/ELF/AArch64/cfi.s:1
+// RUN: llvm-mc -triple aarch64 %s | FileCheck %s --check-prefix=ASM
+// RUN: llvm-mc -filetype=obj -triple aarch64-linux-android %s -o - | llvm-readobj -S --sr --sd - | FileCheck %s
----------------
fmayer wrote:
> The assembly in this file is a copy of test/MC/ELF/cfi.s, with cfi_b_key_frame added. I am not especially fond of this test, and we should maybe change it to use llvm-dwarfinfo instead to get a textual representation.
I agree, but I'm also fine with copying the test first and refactoring both later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135638/new/
https://reviews.llvm.org/D135638
More information about the llvm-commits
mailing list