[PATCH] D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm

Maryam Moghadas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 12:49:27 PDT 2022


maryammo added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10301
+  SDValue VPERMNode =
+      DAG.getNode(Opcode, dl, V1.getValueType(), V1, V2, VPermMask);
+
----------------
amyk wrote:
> Isn't `V1.getValueType()` here just `ValType`?
`V1.getValueType()` is the current valueType for V1 while `ValType` is the original one. (there are possible bitcasts) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133700/new/

https://reviews.llvm.org/D133700



More information about the llvm-commits mailing list