[PATCH] D135733: AMDGPU: Treat asm as a hazard for all register read-after-write hazards

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 12:09:03 PDT 2022


arsenm added a comment.

In D135733#3853303 <https://reviews.llvm.org/D135733#3853303>, @rampitec wrote:

> I don't like this idea. Inserting 19 nops just in case is an overkill.

The scheduler will still try to avoid the hazard, and only for the relevant registers, so it isn't blindly using the worst case. I  don't really care about the performance when using inline asm. It's better to get this correct than continue to waste time debugging these kinds of problems. If people see the nops maybe they'll finally get the message to not use it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135733/new/

https://reviews.llvm.org/D135733



More information about the llvm-commits mailing list