[PATCH] D135714: [MemProf] ThinLTO summary support
Snehasish Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 12 10:01:48 PDT 2022
snehasish added inline comments.
================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:7136
GlobalValue::GUID RefGUID = Record[1];
- ValueIdToValueInfoMap[ValueID] =
- std::make_pair(TheIndex.getOrInsertValueInfo(RefGUID), RefGUID);
+ ValueIdToValueInfoMap[ValueID] = std::make_tuple(
+ TheIndex.getOrInsertValueInfo(RefGUID), RefGUID, RefGUID);
----------------
Can you split out the type change to tuple (along with all the get<X> changes) in a separate patch and submit it as NFC. Then for this patch we will only need to extend the contents of the tuple and touch fewer files?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135714/new/
https://reviews.llvm.org/D135714
More information about the llvm-commits
mailing list