[PATCH] D135788: Precommit for SWDEV-353076: Add check directives to existing tests.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 09:41:53 PDT 2022


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AMDGPU/fnearbyint.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefixes=SI %s
+; RUN: llc -march=amdgcn -mcpu=bonaire -verify-machineinstrs < %s | FileCheck -check-prefixes=CI %s
----------------
Leonc wrote:
> arsenm wrote:
> > Can add a common GCN prefix, the SI and CI cases are mostly identical 
> I got a warning from the update script when I did that. Can it be safely ignored?
> ```
> WARNING: Prefix GCN had conflicting output from different RUN lines for all functions in test ../llvm/test/CodeGen/AMDGPU/fnearbyint.ll
> ```
Yes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135788/new/

https://reviews.llvm.org/D135788



More information about the llvm-commits mailing list