[PATCH] D135446: [libcxxabi] Resync llvm & libcxxabi's demangler

[Nathan Sidwell via Phabricator via llvm-commits]

urnathan added a comment.



In D135446#3852105 <https://reviews.llvm.org/D135446#3852105>, @bader wrote:

> @urnathan, sorry, we didn't notice that https://reviews.llvm.org/D130909 introduces divergence. @steffenlarsen, @jcranmer-intel, FYI.
> Regarding dropping LLVM_ prefix from header guards, it looks like these were removed with some automatic tool (https://github.com/intel/llvm/commit/c13a09a462807936f9eb17cc64f53ad7c9e8ddec), so I would expect someone else will run the tool again and add them back. Any ideas how to prevent this type of changes in the future? Maybe we can keep LLVM_ prefix for sources in llvm/ directory and just ignore this difference. What do you think?

yeah, that;s annoying, the src and dst are not identical anyway, because we insert DO NOT EDIT comments via sed.

I'm sure I can tweak that to modify the idempotency macros. then one can apply the script, and if there's no change in the src version there will also be no change in the dst version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135446/new/

https://reviews.llvm.org/D135446