[PATCH] D134557: [BranchRelaxation] Fall through only if block has no unconditional branches

Anshil Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 09:00:47 PDT 2022


gandhi21299 added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:508-510
+    } else if (FailToAnalyze && (!PrevBB->back().isBarrier() ||
+                                 TII->isPredicated(PrevBB->back()))) {
+      InsertUncondBranch(PrevBB, DestBB);
----------------
arsenm wrote:
> Is this case covered in the test?
I tried out various branching opcodes out there on AMDGPU, none of them satisfied the condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134557/new/

https://reviews.llvm.org/D134557



More information about the llvm-commits mailing list