[PATCH] D135453: [SelectionDAG] Use consistent type sizes for opcode

Wed Oct 12 07:40:17 PDT 2022

mbrkusanin added a comment.

In D135453#3852683 <https://reviews.llvm.org/D135453#3852683>, @foad wrote:

> In D135453#3852611 <https://reviews.llvm.org/D135453#3852611>, @mbrkusanin wrote:
>
>> sizeof(SDNode) went from 88 to 96.
>
> NodeType and NodeBitfields are supposed to pack into a 32-bit word. Maybe you could swap "uint16_t PersistentId;" to the start of the struct instead, and pack that with the NodeBitfields, to avoid increasing the size?

Great idea. That works. SDNode size is now 88.

'--time-passes -track-memory' now looks identical.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135453/new/

https://reviews.llvm.org/D135453